by Ben Gibson and Carlos Ruiz
Have you ever submitted code for review that is working perfectly and has great unit tests, but the response you get is, "Oh, we use tabs for indentation" or "We use ALL_CAPS_WITH_UNDERSCORES for static variable names. Please change, thx!"?
Even though these fixes are easy to make, it can still frustrating that you didn't know about these standards beforehand. Or maybe you tried to figure them out by searching the company wiki but you found conflicting results. Either way, it can be painful that word of mouth was needed to figure out something so trivial.
And It can be even more painful when developers remember different versions of the standards. When that happens, you get something like this:
Finish changes. Assign for code review. Implement changes based on first code review. Submit for second code review. Second reviewer tells you a different "right" way. Interrupt everyone's day for a discussion between you, reviewer #1, reviewer #2, the most senior developer on your team. Agree on something. Update wikis. Write an email to the team. Cross your fingers and hope people read it. Wash. Rinse. Repeat...
Now, that's enough to make you tear your hair out!
The Solution: Never Fear. Automated Tests Are Here!
It doesn't have to be painful. Many (or all) of the standards that we share by word of mouth or wiki documentation can be enforced with static analysis.
"You want to name your file that way?..." BZZZ! Automated test failure!
"You put a space in between your function name and the open paren?..." BZZZ! Automated test failure!
If You Still Need Convincing
Here are just a few of the benefits of using automated tests to enforce standards.
- Faster and easier rampup for new developers.
- Less back and forth during code review.
- Consistency in code and code reviews.
- Reviewers can focus on important feedback.
- Quicker time to market (because of less back and forth).
Examples at Edmunds
- Indenting: Not 1 tab. Not 2 spaces. Not 8 spaces. 4 spaces.
- Semicolons to end statements: ALWAYS.
- Global variables: NOPE. Not allowed.
Here are more early example where everyone knew the rules/conventions, but because we did not automated tests we always had inconstancies. The typical excuse for these failures was laziness... I mean time-crunch.
- Monolithic classes
- “Paul Bunyan tall” functions
- Thirty-nine argument functions
- If and callback nesting and nesting and nesting and nesting... (Pyramid of Doom anyone?)
These are some of the scenarios that we now catch with automated tests.
You don't have to stop at trivial tests either. Why not go farther and implement source lines of code validations (ie. "Your function/class can only X lines long")? Or you can add cyclomatic complexity checks (ie. "You want me to read _that_ spaghetti code?"). We have recently added these tests to our front end code and it has made our lives and code much more beautiful.
Think of self-governing code as the logical extension of self-documenting code. Use automated tests whenever possible, and make sure you have tests for any "standards" you put in place.
Ben Gibson has been at Edmunds for one year working as a Front End Engineer. He is currently working on a User Generated Content project that aims to improve user experience submitting reviews for consumers, auto repair services, and dealerships. In his spare time he enjoys recording music and traveling with his wife.
Carlos Ruiz was born and raised in Los Angeles and has rocked the Sr. Front End Engineer position at Edmunds.com for the past 5 years. He is currently working on a top secret Edmunds front-end project. Carlos loves all foods, but seafood, and drinks coffee only at Edmunds.
Authors: Ben Gibson, Carlos Ruiz
Editors: Gina Shaw, Heather Tipple Yang, Kelly Stacy